Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add habibi.pdf from https://github.com/py-pdf/PyPDF2/issues/1111 #13

Merged
merged 3 commits into from
Jul 17, 2022

Conversation

dkg
Copy link
Contributor

@dkg dkg commented Jul 17, 2022

No description provided.

@MartinThoma
Copy link
Member

Nice!

Could you please add an entry for the pdf in https://github.com/py-pdf/sample-files/blob/main/files.json? This json allows us to run automated tests over all files (the thought was that other projects could find interesting test cases with that file more easily)

@dkg
Copy link
Contributor Author

dkg commented Jul 17, 2022

good call, @MartinThoma ! i'll add both files to files.json in a minute here.

(note: habibi-oneline-cmap.pdf was made with a manual tweak to
habibi.pdf, as documented in README.md, so i've added "+manual" to the
producer string)
@MartinThoma MartinThoma merged commit 200644f into py-pdf:main Jul 17, 2022
@MartinThoma
Copy link
Member

Thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants