Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pdf reader getting stuck on large files without startxref marker #295

Closed
wants to merge 1 commit into from
Closed

fix pdf reader getting stuck on large files without startxref marker #295

wants to merge 1 commit into from

Conversation

dsk7
Copy link
Contributor

@dsk7 dsk7 commented Oct 22, 2016

No description provided.

@dsk7
Copy link
Contributor Author

dsk7 commented Oct 22, 2016

Hi! We found a bug where PyPDF got stuck on a certain kind of broken files.
This pull request adds a test and fixes the bug.

Happy coding
dsk7

@vstoykov
Copy link
Contributor

The test is not Python3 compatible. In Python 3 there is no StringIO package.

@MartinThoma MartinThoma added is-bug From a users perspective, this is a bug - a violation of the expected behavior with a compliant PDF Tiny Pull requests that make a tiny change - and thus should be easy to merge labels Apr 6, 2022
@MartinThoma MartinThoma added nf-security Non-functional change: Security is-robustness-issue From a users perspective, this is about robustness labels Apr 16, 2022
@MartinThoma
Copy link
Member

@dsk7 Thank you for your PR - sorry that it took so long.

Would you mind to resolve the merge conflicts?

@MartinThoma MartinThoma added the needs-change The PR/issue cannot be handled as issue and needs to be improved label Apr 16, 2022
@dsk7 dsk7 closed this Apr 23, 2022
@dsk7 dsk7 deleted the master branch April 23, 2022 09:05
@dsk7 dsk7 restored the master branch April 23, 2022 09:08
@dsk7
Copy link
Contributor Author

dsk7 commented Apr 23, 2022

I'll have a look at it!

@dsk7 dsk7 reopened this Apr 23, 2022
@dsk7
Copy link
Contributor Author

dsk7 commented Apr 23, 2022

I had a look: The solution suggested here is not compatible with the changes made in the mean time. I'll open a new pull request following a different (and much better) route.

@dsk7 dsk7 closed this Apr 23, 2022
@dsk7 dsk7 deleted the master branch April 23, 2022 14:36
@MartinThoma
Copy link
Member

Replaced by #808 and that one was merged 🎉 - the release will be in April (some time in the next few days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
is-bug From a users perspective, this is a bug - a violation of the expected behavior with a compliant PDF is-robustness-issue From a users perspective, this is about robustness needs-change The PR/issue cannot be handled as issue and needs to be improved nf-security Non-functional change: Security Tiny Pull requests that make a tiny change - and thus should be easy to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsk7 @vstoykov @MartinThoma