Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Add deprecate_with_replacement to StreamObject.initializeFromD… #2728

Merged
merged 4 commits into from
Jun 27, 2024
Merged

MAINT: Add deprecate_with_replacement to StreamObject.initializeFromD… #2728

merged 4 commits into from
Jun 27, 2024

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Jun 27, 2024

…ictionary

@codecov Codecov
Copy link

codecov bot commented Jun 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (160ab38) to head (8149847).
Report is 66 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2728   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files          51       51           
  Lines        8547     8549    +2     
  Branches     1703     1703           
=======================================
+ Hits         8132     8134    +2     
  Misses        261      261           
  Partials      154      154

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pubpub-zz
Copy link
Collaborator

I'm wondering if the comment was not here to ignore coverage only

@stefan6419846
Copy link
Collaborator

@pubpub-zz But we already had the correctly named replacement, but no deprecation warning for it. Thus the comment does not really make sense here and rather looks like an oversight. Nevertheless, we should probably consider adding at least a no coverage pragma to the offending line.

@pubpub-zz pubpub-zz merged commit f893a6b into py-pdf:main Jun 27, 2024
16 checks passed
@j-t-1 j-t-1 deleted the deprecate branch June 28, 2024 06:56
MartinThoma added a commit that referenced this pull request Jul 21, 2024
@MartinThoma
REL: 4.3.1
d85dbe9 
## What's new

### Bug Fixes (BUG)
- Cope with Matrix entry in field annotations (#2736)

### Robustness (ROB)
- Cope with fields with upside down box/rectangle (#2729) by @pubpub-zz

### Documentation (DOC)
- Update Link Documentation Example (#2759) by @jparris
- Make table consistent with pdf-version-support.md (#2758) by @j-t-1
- Add feature support by pypdf (#2738) by @j-t-1
- Move JavaScript example (#2746) by @j-t-1
- Added example for downloading a PDF from Google Cloud Storage  (#2745) by @prodeveloper
- Miscellaneous tiny changes (#2744) by @j-t-1
- Amend comment with rectangle duplication (#2733) by @j-t-1
- Use enumerate in extract example (#2727) by @j-t-1
- Tiny changes (#2723) by @j-t-1

### Maintenance (MAINT)
- Remove redundant pass statement (#2739) by @j-t-1
- Update Python version support documentation (#2740) by @j-t-1
- Remove redundant super() (#2734) by @j-t-1
- Add deprecate_with_replacement to StreamObject.initializeFromD… (#2728) by @j-t-1

### Code Style (STY)
- Change argument type (#2741) by @j-t-1
- Use endswith instead of logical equals (#2732) by @j-t-1

[Full Changelog](4.3.0...4.3.1)
@MartinThoma MartinThoma mentioned this pull request Jul 21, 2024
Merged
stefan6419846 pushed a commit that referenced this pull request Jul 21, 2024
@MartinThoma
REL: 4.3.1
8f62120 
## What's new

### Bug Fixes (BUG)
- Cope with Matrix entry in field annotations (#2736) by @pubpub-zz

### Robustness (ROB)
- Cope with fields with upside down box/rectangle (#2729) by @pubpub-zz

### Documentation (DOC)
- Update Link Documentation Example (#2759) by @jparris
- Make table consistent with pdf-version-support.md (#2758) by @j-t-1
- Add feature support by pypdf (#2738) by @j-t-1
- Move JavaScript example (#2746) by @j-t-1
- Added example for downloading a PDF from Google Cloud Storage  (#2745) by @prodeveloper
- Miscellaneous tiny changes (#2744) by @j-t-1
- Amend comment with rectangle duplication (#2733) by @j-t-1
- Use enumerate in extract example (#2727) by @j-t-1
- Tiny changes (#2723) by @j-t-1

### Maintenance (MAINT)
- Remove redundant pass statement (#2739) by @j-t-1
- Update Python version support documentation (#2740) by @j-t-1
- Remove redundant super() (#2734) by @j-t-1
- Add deprecate_with_replacement to StreamObject.initializeFromDictionary (#2728) by @j-t-1
- Deal with cryptography>=43 moving ARC4 (#2765) by @MartinThoma

### Code Style (STY)
- Change argument type (#2741) by @j-t-1
- Use endswith instead of logical equals (#2732) by @j-t-1

[Full Changelog](4.3.0...4.3.1)
@pubpub-zz pubpub-zz mentioned this pull request Aug 11, 2024
Closed
pubpub-zz added a commit to pubpub-zz/pypdf that referenced this pull request Aug 11, 2024
@pubpub-zz
ENH: compress pdf files merging identical objects
8d30c88 
add compress_identical_objects()
discovered in py-pdf#2728
closes py-pdf#2794
closes py-pdf#2768
@pubpub-zz pubpub-zz mentioned this pull request Aug 11, 2024
Merged
stefan6419846 pushed a commit that referenced this pull request Aug 13, 2024
@pubpub-zz
ENH: Compress PDF files merging identical objects (#2795)
cf7fcfd 
Add compress_identical_objects().
Discovered in #2728.
Closes #2794.
Closes #2768.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pubpub-zz pubpub-zz pubpub-zz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-t-1 @pubpub-zz @stefan6419846