BUG: Correctly handle image mode 1 with FlateDecode #2249
Conversation
|
I am not sure about the AES failures in this case, which seems to be an issue wit older Python versions and the used test file. In theory we could skip the tests for Python < 3.9(?), but this does not really seem right. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2249 +/- ##
=======================================
Coverage 94.44% 94.45%
=======================================
Files 43 43
Lines 7621 7622 +1
Branches 1502 1501 -1
=======================================
+ Hits 7198 7199 +1
Misses 261 261
Partials 162 162
☔ View full report in Codecov by Sentry. |
|
@exiledkingcc Could you please have a look at it? |
|
As another data point: It seems like this only affects Python 3.7 where neither For reference: https://github.com/stefan6419846/pypdf/actions/runs/6469234606/ uses the same code as the branch of this PR, but with fail-fast disabled compared to the "original" PR run in https://github.com/py-pdf/pypdf/actions/runs/6458194919/ |
|
the test pdf file is encrypted with empty password. so is ok to skip if no AES decrypting. |
|
@MartinThoma I would argue that we could indeed merge this then. Discussing how to continue with one Python version not being tested with encryption should probably be a separate issue/PR in this case - just adding another matrix entry should be sufficient and if desired, I am open to providing a corresponding PR for it. |
|
Thank you @stefan6419846 for reporting the issue and for fixing it 🙏 Yes, it would be nice to complete our CI to ensure we don't have relevant gaps in test coverage |
|
@exiledkingcc Thanks for having a look 🙏 |
## What's new ### Security (SEC) - Infinite recursion when using PdfWriter(clone_from=reader) (#2264) by @Alexhuszagh ### New Features (ENH) - Add parameter to select images to be removed (#2214) by @pubpub-zz ### Bug Fixes (BUG) - Correctly handle image mode 1 with FlateDecode (#2249) by @stefan6419846 - Error when filling a value with parentheses #2268 (#2269) by @KanorUbu - Handle empty root outline (#2239) by @pubpub-zz ### Documentation (DOC) - Improve merging docs (#2247) by @stefan6419846 ### Developer Experience (DEV) - Test Python 3.7 with cryptopgraphy provider as well (#2276) by @stefan6419846 - Run CI with windows-latest (#2258) by @MartinThoma - Use pytest-xdist (#2254) by @MartinThoma - Attribute correct authors in the release notes (#2246) by @stefan6419846 ### Maintenance (MAINT) - Apply pre-commit hooks (#2277) by @MartinThoma - Update requirements + mypy fixes (#2275) by @MartinThoma - Explicitly provide Any for IO generic argument (#2272) by @nilehmann ### Testing (TST) - Fix test_image_without_pillow in windows environment (#2257) by @pubpub-zz ### Code Style (STY) - Remove unused import by @MartinThoma [Full Changelog](3.16.4...3.17.0)
Fixes #2248.