Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add metadata.creation_date and modification_date #1364

Merged
merged 3 commits into from
Sep 24, 2022
Merged

Conversation

MartinThoma
Copy link
Member

Closes #1222

@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

Base: 94.55% // Head: 94.53% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (1b0cf15) compared to base (85b3e87).
Patch coverage: 89.47% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1364      +/-   ##
==========================================
- Coverage   94.55%   94.53%   -0.02%     
==========================================
  Files          28       28              
  Lines        5016     5035      +19     
  Branches     1033     1035       +2     
==========================================
+ Hits         4743     4760      +17     
- Misses        164      165       +1     
- Partials      109      110       +1     
Impacted Files Coverage Δ
PyPDF2/_reader.py 89.57% <89.47%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma MartinThoma merged commit 2845c6d into main Sep 24, 2022
@MartinThoma MartinThoma deleted the metadata-types branch September 24, 2022 12:58
@MartinThoma
Copy link
Member Author

Thank you 🙏

If you want, I can add you as a contributor https://pypdf2.readthedocs.io/en/latest/meta/CONTRIBUTORS.html

MartinThoma added a commit that referenced this pull request Sep 25, 2022
New Features (ENH):
-  Addition of optional visitor-functions in extract_text() (#1252)
-  Add metadata.creation_date and modification_date (#1364)
-  Add PageObject.images attribute (#1330)

Bug Fixes (BUG):
-  Lookup index in _xobj_to_image can be ByteStringObject (#1366)
-  \'IndexError: index out of range\' when using extract_text (#1361)
-  Errors in transfer_rotation_to_content() (#1356)

Robustness (ROB):
-  Ensure update_page_form_field_values does not fail if no fields (#1346)

Testing (TST):
-  read_string_from_stream performance (#1355)

Full Changelog: 2.10.9...2.11.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unspecific type hints for reader.metadata
1 participant