Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add with ... as ... usage #1117

Closed
wants to merge 34 commits into from
Closed

Add with ... as ... usage #1117

wants to merge 34 commits into from

Commits on Jul 15, 2022

  1. Add with ... as ... usage (#1108)

    @JianzhengLuo
    JianzhengLuo committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    a2b7b55 View commit details
    Browse the repository at this point in the history

  2. Update PyPDF2/_merger.py according to @MasterOdin's suggestions 

    Co-authored-by: Matthew Peveler <[email protected]>
    @JianzhengLuo @MasterOdin
    JianzhengLuo and MasterOdin authored Jul 15, 2022
    Configuration menu
    Copy the full SHA
    2a88bd5 View commit details
    Browse the repository at this point in the history

  3. Update PyPDF2/_merger.py according to @MasterOdin's suggestions

    @JianzhengLuo
    JianzhengLuo committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    b6d0351 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2022

  1. Update PyPDF2/_merger.py according to @MasterOdin's suggestions

    @JianzhengLuo
    JianzhengLuo committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    80813aa View commit details
    Browse the repository at this point in the history

  2. Update PyPDF2/_merger.py according to @MasterOdin's suggestions

    @JianzhengLuo
    JianzhengLuo committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    e6ec1f6 View commit details
    Browse the repository at this point in the history

  3. Update PyPDF2/_merger.py according to @MasterOdin's suggestions

    @JianzhengLuo
    JianzhengLuo committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    386be5b View commit details
    Browse the repository at this point in the history

  4. Sorry, I forgot to run before committing, so didn't notice that `Trac… 

    …ebackType` is from `typing` but from `types`.
    @JianzhengLuo
    JianzhengLuo committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    31786bb View commit details
    Browse the repository at this point in the history

  5. Modify the wrong closing place that cause.

    @JianzhengLuo
    JianzhengLuo committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    ae1bec0 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2022

  1. Merge branch 'main' into add-with-as-usage-#1108

    @JianzhengLuo
    JianzhengLuo authored Jul 17, 2022
    Configuration menu
    Copy the full SHA
    0b7c64e View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. Modify PyPDF2/_writer.py according to @MasterOdin's suggestions 

    Co-authored-by: Matthew Peveler <[email protected]>
    @JianzhengLuo @MasterOdin
    JianzhengLuo and MasterOdin authored Jul 18, 2022
    Configuration menu
    Copy the full SHA
    b695113 View commit details
    Browse the repository at this point in the history

  2. Modify PyPDF2/_writer.py according to @MasterOdin's suggestions 

    Co-authored-by: Matthew Peveler <[email protected]>
    @JianzhengLuo @MasterOdin
    JianzhengLuo and MasterOdin authored Jul 18, 2022
    Configuration menu
    Copy the full SHA
    58797c2 View commit details
    Browse the repository at this point in the history

  3. Modify PyPDF2/_writer.py according to @MasterOdin's suggestions 

    Co-authored-by: Matthew Peveler <[email protected]>
    @JianzhengLuo @MasterOdin
    JianzhengLuo and MasterOdin authored Jul 18, 2022
    Configuration menu
    Copy the full SHA
    1caa9ec View commit details
    Browse the repository at this point in the history

  4. Modify PyPDF2/_writer.py according to @MasterOdin's suggestions 

    Co-authored-by: Matthew Peveler <[email protected]>
    @JianzhengLuo @MasterOdin
    JianzhengLuo and MasterOdin authored Jul 18, 2022
    Configuration menu
    Copy the full SHA
    4fbe3cc View commit details
    Browse the repository at this point in the history

  5. Modify PyPDF2/_writer.py according to @MasterOdin's suggestions

    @JianzhengLuo
    JianzhengLuo committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    d598e8a View commit details
    Browse the repository at this point in the history

  6. Merge branch 'add-with-as-usage-#1108' of https://github.com/Jianzhen… 

    …gLuo/PyPDF2 into add-with-as-usage-#1108
    @JianzhengLuo
    JianzhengLuo committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    7ecf9ff View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Merge branch 'main' into add-with-as-usage-#1108

    Jianzheng Luo authored Jul 19, 2022
    Configuration menu
    Copy the full SHA
    562ebc7 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. Fix accident

    @JianzhengLuo
    JianzhengLuo committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    519dad1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'add-with-as-usage-#1108' of https://github.com/Jianzhen… 

    …gLuo/PyPDF2 into add-with-as-usage-#1108
    @JianzhengLuo
    JianzhengLuo committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    336053a View commit details
    Browse the repository at this point in the history

  3. Fix error raising while using half traditional usage

    @JianzhengLuo
    JianzhengLuo committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    90af68a View commit details
    Browse the repository at this point in the history

  4. Add a unit test (Problems still exist, please help.)

    @JianzhengLuo
    JianzhengLuo committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    0f67658 View commit details
    Browse the repository at this point in the history

  5. Update PyPDF2/_merger.py according to @MartinThoma's suggestions 

    Co-authored-by: Martin Thoma <[email protected]>
    @JianzhengLuo @MartinThoma
    JianzhengLuo and MartinThoma authored Jul 21, 2022
    Configuration menu
    Copy the full SHA
    a6f973e View commit details
    Browse the repository at this point in the history

  6. Modify PyPDF2/_merger.py according to flake8

    @JianzhengLuo
    JianzhengLuo committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    580ad8c View commit details
    Browse the repository at this point in the history

  7. Modify to compatible with the existing usage

    @JianzhengLuo
    JianzhengLuo committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    bf264bc View commit details
    Browse the repository at this point in the history

  8. Modify to compatible with the with .. as ... usage

    @JianzhengLuo
    JianzhengLuo committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    c705300 View commit details
    Browse the repository at this point in the history

  9. Removed a meaningless annotation

    @JianzhengLuo
    JianzhengLuo committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    2940589 View commit details
    Browse the repository at this point in the history

  10. Fixed wrong test function names

    @JianzhengLuo
    JianzhengLuo committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    cda38ac View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. Fixed those I can fix only.

    @JianzhengLuo
    JianzhengLuo committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    0b18198 View commit details
    Browse the repository at this point in the history

  2. Removed useless else section 

    Co-authored-by: Martin Thoma <[email protected]>
    @JianzhengLuo @MartinThoma
    JianzhengLuo and MartinThoma authored Jul 22, 2022
    Configuration menu
    Copy the full SHA
    62f970f View commit details
    Browse the repository at this point in the history

  3. Renamed argument name fileobj back to stream to keep the existing… 

    … workflow

Co-authored-by: Martin Thoma <[email protected]>
    @JianzhengLuo @MartinThoma
    JianzhengLuo and MartinThoma authored Jul 22, 2022
    Configuration menu
    Copy the full SHA
    d85c91b View commit details
    Browse the repository at this point in the history

  4. Modified annoation for PdfWriter().write() and `PdfWriter().write_s… 

    …tream()`
    @JianzhengLuo
    JianzhengLuo committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    5cd3f3e View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2022

  1. Switched fileobj and strict in initializing PdfWriter() to keep… 

    … the existing workflow

Co-authored-by: Matthew Peveler <[email protected]>
    @JianzhengLuo @MasterOdin
    JianzhengLuo and MasterOdin authored Jul 23, 2022
    Configuration menu
    Copy the full SHA
    a7346ef View commit details
    Browse the repository at this point in the history

  2. Modified annoation to make the it match the arguments

    @JianzhengLuo
    JianzhengLuo committed Jul 23, 2022
    Configuration menu
    Copy the full SHA
    d3e62ee View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2022

  1. Modified undefined name fileobj

    @JianzhengLuo
    JianzhengLuo committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    59be94d View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Merge branch 'main' into add-with-as-usage-#1108

    @MartinThoma
    MartinThoma authored Aug 1, 2022
    Configuration menu
    Copy the full SHA
    092f209 View commit details
    Browse the repository at this point in the history