Use faster ItsDrike/setup-poetry in favor of HassanAbouelela/actions/setup-python #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsDrike
added
type: enhancement
ItsDrike
force-pushed
the
switch-setup-poetry-action
branch
from
8f12db6
to
6524154
Compare
ItsDrike
changed the title
ItsDrike
force-pushed
the
switch-setup-poetry-action
branch
from
f705e2e
to
13826c2
Compare
kevinkjt2000
approved these changes
Feb 16, 2023
PerchunPak
requested changes
Feb 17, 2023
Having this cache saves about 200ms from the pytest run, however the cache restoring alone often takes longer, especially on windows, meaning it actually slows the CI down on average.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all workflows that require dependency installation with poetry to use
ItsDrike/setup-poetrywhich is significantly faster to the currentHassanAbouelela/actions/setup-python.For an in-depth description of what's changed, feel free to check py-mine/mcproto#12, which was a PR with same goal (moving from HassanAbouelela/actions/setup-python to ItsDrike/setup-poetry). It's description includes a performance analysis, comparing the actual times action runs took between these two, and mentions some caveats that switch has.
For a quick overview, here's the important things:
Improvements this switch brings us
ItsDrike/setup-poetryaction, ahead of time, not as post hooks, meaning whenever dependency installation step succeeds, caches will be created, even if the action fails in some step later on.Extra enhancements
HassanAbouelela/actions/setup-pythonwas also caching pre-commit environments (at least for linux where caching actually worked), which theItsDrike/setup-poetryis not doing. For that reason, an additional step was added specifically to cache the pre-commit environment in the validation workflow.Note
As this change will now be installing poetry globally, rather than as one of the project's dependencies, making it a part of the project's venv binaries, to make tox work with poetry installations in the CI, adding
poetrydependency to theworkflow-toxgroup was necessary.However this doesn't affect end users nor developers, as this dependency group is only used within the workflows.