Use | instead of typing.Union, typing.Optional (PEP 604)
#386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerchunPak
force-pushed
the
pep-604
branch
2 times, most recently
from
9954220
to
2f58598
Compare
ItsDrike
added
type: enhancement
PerchunPak
force-pushed
the
pep-604
branch
2 times, most recently
from
4652b39
to
00e8497
Compare
ItsDrike
requested changes
Sep 3, 2022
PerchunPak
force-pushed
the
pep-604
branch
2 times, most recently
from
4713678
to
4de8383
Compare
PerchunPak
force-pushed
the
pep-604
branch
2 times, most recently
from
014f106
to
8d489fd
Compare
ItsDrike
requested changes
Sep 19, 2022
ItsDrike
approved these changes
Sep 19, 2022
kevinkjt2000
approved these changes
Sep 29, 2022
Why am I using `flake8-new-union-types`, and not `flake8-pep604`? Second one is checking only imports and only `typing.Union`, `typing.Optional` was ignored. (Inspired by py-mine#375)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why am I using
flake8-new-union-types, and notflake8-pep604? Second one is checking only imports and onlytyping.Union,typing.Optionalwas ignored.(Inspired by #375. There are also description why this will work on 3.7, even if was added only in 3,10)