Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More predict tests #683

Merged
merged 8 commits into from
Nov 1, 2024
Merged

More predict tests #683

merged 8 commits into from
Nov 1, 2024

Conversation

s3alfisc
Copy link
Member

Add direct tests against fixest with newdata argument supplied.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pyfixest/estimation/feols_.py 66.66% 2 Missing ⚠️
Flag Coverage Δ
core-tests 77.68% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pyfixest/estimation/feols_.py 82.99% <66.66%> (-0.11%) ⬇️

@s3alfisc s3alfisc merged commit 4ae926e into master Nov 1, 2024
8 of 9 checks passed
@s3alfisc s3alfisc deleted the more-predict-tests branch November 1, 2024 09:44
marcandre259 pushed a commit to marcandre259/pyfixest that referenced this pull request Nov 13, 2024
* add info on discourse to docs

* test predict with newdata against fixest

* updates

* pass tests

* fix test bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant