Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in fixef() method for WLS #682

Merged
merged 7 commits into from
Oct 29, 2024
Merged

Bugfix in fixef() method for WLS #682

merged 7 commits into from
Oct 29, 2024

Conversation

s3alfisc
Copy link
Member

See #678 for details.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
core-tests 77.70% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pyfixest/estimation/feols_.py 83.09% <100.00%> (+0.11%) ⬆️

... and 2 files with indirect coverage changes

@s3alfisc s3alfisc merged commit a3ed27a into master Oct 29, 2024
9 checks passed
@s3alfisc s3alfisc deleted the wls-fixef-bug branch October 29, 2024 19:12
marcandre259 pushed a commit to marcandre259/pyfixest that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Incorrect prediction with WLS anf fixed effects and newdata not None
1 participant