-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reopen iterative rectifier PR #660
Reopen iterative rectifier PR #660
Conversation
We have a very small test error: def test_separation():
"""Test separation detection."""
y = np.array([0, 0, 0, 1, 2, 3])
df1 = np.array(["a", "a", "b", "b", "b", "c"])
df2 = np.array(["c", "c", "d", "d", "d", "e"])
x = np.random.normal(0, 1, 6)
df = pd.DataFrame({"Y": y, "fe1": df1, "fe2": df2, "x": x})
with pytest.warns(
UserWarning, match="2 observations removed because of separation."
):
> fepois("Y ~ X | fe1", data=example1, vcov="hetero", separation_check=["fe"]) # noqa: F841
E NameError: name 'example1' is not defined
tests/test_poisson.py:34: NameError I think renaming |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
pre-commit.ci autofix |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
…e/pyfixest into iterative-rectifier-2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added minor changes. I think this is good to merge now! Thanks Leo @leostimpfle =)
Reopens the original PR #534 as discussed with @s3alfisc