Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopen iterative rectifier PR #660

Merged
merged 15 commits into from
Oct 22, 2024

Conversation

leostimpfle
Copy link
Collaborator

@leostimpfle leostimpfle commented Oct 20, 2024

Reopens the original PR #534 as discussed with @s3alfisc

@s3alfisc
Copy link
Member

We have a very small test error:

    def test_separation():
        """Test separation detection."""
        y = np.array([0, 0, 0, 1, 2, 3])
        df1 = np.array(["a", "a", "b", "b", "b", "c"])
        df2 = np.array(["c", "c", "d", "d", "d", "e"])
        x = np.random.normal(0, 1, 6)
    
        df = pd.DataFrame({"Y": y, "fe1": df1, "fe2": df2, "x": x})
    
        with pytest.warns(
            UserWarning, match="2 observations removed because of separation."
        ):
>           fepois("Y ~ X  | fe1", data=example1, vcov="hetero", separation_check=["fe"])  # noqa: F841
E           NameError: name 'example1' is not defined

tests/test_poisson.py:34: NameError

I think renaming data = example1 to data = df should solve this =)

@s3alfisc
Copy link
Member

pre-commit.ci autofix

@s3alfisc
Copy link
Member

pre-commit.ci autofix

@s3alfisc
Copy link
Member

pre-commit.ci autofix

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 89.55224% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pyfixest/estimation/fepois_.py 88.52% 7 Missing ⚠️
Flag Coverage Δ
core-tests 77.62% <89.55%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pyfixest/estimation/FixestMulti_.py 80.71% <100.00%> (+0.09%) ⬆️
pyfixest/estimation/estimation.py 95.87% <100.00%> (+0.22%) ⬆️
pyfixest/estimation/fepois_.py 87.55% <88.52%> (-0.25%) ⬇️

@s3alfisc
Copy link
Member

pre-commit.ci autofix

@s3alfisc s3alfisc self-requested a review October 21, 2024 20:23
Copy link
Member

@s3alfisc s3alfisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor changes. I think this is good to merge now! Thanks Leo @leostimpfle =)

@leostimpfle leostimpfle merged commit 8435537 into py-econometrics:master Oct 22, 2024
8 checks passed
@leostimpfle leostimpfle deleted the iterative-rectifier-2 branch October 26, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants