Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to use Great Tables package for table output #591

Merged
merged 14 commits into from
Aug 28, 2024

Conversation

dsliwka
Copy link
Contributor

@dsliwka dsliwka commented Aug 26, 2024

Add option to use the Great Tables package for table output type. Added instructions in the stargazer.ipynb notbook.

…ed instructions in the stargazer.ipynb notbook.
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

docs/stargazer.ipynb Show resolved Hide resolved
docs/stargazer.ipynb Show resolved Hide resolved
@s3alfisc
Copy link
Member

Added great_tables to the deps & re-build the lock files + left some small comments. The tables look amazing @dsliwka!

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 95.50562% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pyfixest/report/summarize.py 93.54% 2 Missing ⚠️
pyfixest/report/visualize.py 97.77% 1 Missing ⚠️
pyfixest/utils/dgps.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
pyfixest/utils/dev_utils.py 84.81% <100.00%> (ø)
pyfixest/utils/utils.py 92.00% <ø> (ø)
tests/test_did.py 100.00% <100.00%> (ø)
tests/test_visualize.py 100.00% <100.00%> (ø)
pyfixest/report/visualize.py 92.90% <97.77%> (ø)
pyfixest/utils/dgps.py 0.00% <0.00%> (ø)
pyfixest/report/summarize.py 90.33% <93.54%> (ø)

... and 26 files with indirect coverage changes

@dsliwka
Copy link
Contributor Author

dsliwka commented Aug 28, 2024

Thanks, @s3alfisc! Just one quick remark. I realized that the tables are rendered differently in VS Code and on the pyfixest website. Then I found this on the quarto website: "It’s possible that Quarto’s processing of HTML tables may interfere with the HTML produced computationally with table packages in R and Python (or other supported languages). You can disable Quarto’s HTML table processing at a document level or project level with the option html-table-processing:" (https://quarto.org/docs/authoring/tables.html). I did that now in the stargazer.ipynb.

@s3alfisc
Copy link
Member

Great, thank you!

@s3alfisc s3alfisc changed the title Optiion to use Great Tables package for table output Option to use Great Tables package for table output Aug 28, 2024
@s3alfisc s3alfisc merged commit 1b4c7cb into py-econometrics:master Aug 28, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants