-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout improvements for etable, in particular for LaTex output #583
Layout improvements for etable, in particular for LaTex output #583
Conversation
…l headers & custom table notes
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you Dirk (@dsliwka)! The examples look phenomenal. I'll review this over the weekend =) On the testing error - I think it is obsolete now because we are now supporting "tex" with the "\n" command (this was not the case before). with pytest.raises(ValueError):
> etable([fit1, fit2], coef_fmt="b (se)\nt [p]", type="tex")
E Failed: DID NOT RAISE <class 'ValueError'> |
Codecov ReportAttention: Patch coverage is
|
…iwka/pyfixest into etables--Layout-Latex-Tables
…bles in a separate latex file or in overleaf will likely not want to see the printed code in the notebook. Moreover, for quarto rendering it must apparently be printed in any case in the end of the code block. When print_tex=True then the rendered document will also show the latex code block in addition to the table).
Thanks for the feedback @s3alfisc! I have added the print_tex option & extended the documentation in the Stargazer notebook. Initially I had set the default option for print_tex=True but then realized that this may have unwanted side-effects. For instance, for pdf rendering to work in quarto the table must apparently be printed in the respective code chunk. When print_tex=True the pdf not only includes the table but also the latex code. |
…ed some issues, I have taken this out of the notebook and instead refer to an added qmd file that gives as an eample for including tables in quarto.
I apologize @s3alfisc for the confusion I cause! Apparently the issue is caused by including a quarto example. I first had it in the Stargazer notebook. I had hoped to solve the issue by taking this out and just adding a sample qmd file and the resulting pdf. But apparently some code is running which tries to render the respective document to pdf and then misses a TeX installation. Is it possible to just keep the document as an example in the repository without having it automatically rendered? Otherwise I can of course simply erase it and take out the respective description in the Stargazer notebook. |
Hi @dsliwka, no worries at all! Looks indeed like quartodoc by default runs the |
…el information/further model statistics.
Thanks @s3alfisc! I think it is perfectly fine to stick to the sample document. |
Hi Dirk, thank you! All of this looks outstanding, and I am more than happy to merge this later today. The |
Changes to generate publication-ready LaTex Tables: