Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update quickstart for IV first stage, diagnostics, Wald tests #569

Merged
merged 9 commits into from
Aug 1, 2024

Conversation

s3alfisc
Copy link
Member

  • Updates the quickstart notebooks.
  • Adds a section on IV diagnostics and first stage.
  • Adds a section on wald tests.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@s3alfisc s3alfisc requested a review from Jayhyung July 31, 2024 19:11
@s3alfisc s3alfisc linked an issue Jul 31, 2024 that may be closed by this pull request
docs/quickstart.ipynb Outdated Show resolved Hide resolved
@@ -34,14 +34,14 @@
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a really nice and concise introduction! I think there is no additional stuff to do. I will add more to this part when I add other diagnostic IV related tests!


Reply via ReviewNB

docs/quickstart.ipynb Outdated Show resolved Hide resolved
@s3alfisc s3alfisc merged commit eb9d5ba into master Aug 1, 2024
6 checks passed
@s3alfisc s3alfisc deleted the iv-docs branch August 1, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add note on wald_test method to quickstart (or even a new notebook)?
2 participants