Improve checks on github.ref fields

[ollaw]

This PR arises from the problem of having "pull" substring inside your branch name.

In particular, having a branch name like ISSUE-XXX/task/enable-pull-lorem-ipsum causes a crash in the action since the if inside GITHUB_PR_NUMBER property wrongly assumes that github.ref refers to a PR, and tries to cast to integer the PR number.

Goal of this PR is to make the check a bit stronger, for both GITHUB_PR_NUMBER and GITHUB_BRANCH_NAME (since it's easier to incur in same problem with a tags that contains "heads" substring inside it) checking github.ref head rather than randomly checking that a word is inside it.

[github-actions]

End-to-end public repo

Admin commands cheatsheet:

• /e2e (in approved PR review body): Trigger end-to-end tests on external contributions
• /invite (in comment): Invite the author & admins to the end-to-end private repo

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
coverage_comment
settings.py
Project Total

This report was generated by python-coverage-comment-action

[ewjoachim]

Damn, of course 🤦

Thanks for the contribution, would you mind adding a couple of tests in https://github.com/py-cov-action/python-coverage-comment-action/blob/main/tests/unit/test_settings.py#L126-L145 to ensure we don't get a regression ? Thanks !

[ewjoachim]

I think I never thought it would happen because I've mainly tested with on: pull_request whereas I guess you're experiencing this with on: push ?

[ollaw]

whereas I guess you're experiencing this with on: push ?

Exactly, I also unfairly blamed GtiHub at first, I thought there was some problem on push / pull_request triggers 😄

would you mind adding a couple of tests [...] ?

Sure, take a look if that's okay.

[ewjoachim]

Perfect 🤩

[ewjoachim]

https://github.com/py-cov-action/python-coverage-comment-action/releases/tag/v3.24