Fix cases where the datafile is huge #360
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the json datafile is >1MB, the default mode of the Github content API is to skip the content and provide a link to it.
If we use header
Accept: application/vnd.github.raw+json
, the application will:Content-Type: application/vnd.github.raw+json
This PR:
Accept
header to the datafile functionContent-Type
response header makes return text instead of bytes. (I'm not 100% sure it's what we should do but we can always revert this later).