Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group annotations for (almost) contiguous lines #323

Merged
merged 5 commits into from
Dec 25, 2023
Merged

Conversation

ewjoachim
Copy link
Member

@ewjoachim ewjoachim commented Dec 22, 2023

Closes #322

Groups multiple annotations into a single one with line and lineEnd, where all the lines in the groups are missing coverage, authorizing gaps in the middle of groups as long as they are shorter than 3 lines and don't contain a covered or an excluded line.

I think I'm not satisfied. I would like to authorize arbitrary gaps when all the lines in the gap are added in the diff.

Copy link

End-to-end public repo

Copy link

github-actions bot commented Dec 22, 2023

Coverage report

The coverage rate went from 100% to 100% ➡️
The branch rate is 100%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

coverage_comment/annotations.py

100% of new lines are covered (100% of the complete file).

coverage_comment/coverage.py

100% of new lines are covered (100% of the complete file).

coverage_comment/github.py

100% of new lines are covered (100% of the complete file).

coverage_comment/main.py

100% of new lines are covered (100% of the complete file).

coverage_comment/settings.py

100% of new lines are covered (100% of the complete file).

@ewjoachim ewjoachim marked this pull request as ready for review December 24, 2023 09:37
@ewjoachim ewjoachim merged commit 01fa035 into main Dec 25, 2023
2 checks passed
@ewjoachim ewjoachim deleted the group-annotations branch December 25, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"missing line" annotations that span multiple lines?
1 participant