Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.3 - Make API Gateway optional #291

Closed
4 tasks done
huntharo opened this issue Jan 8, 2023 · 0 comments · Fixed by #292
Closed
4 tasks done

v0.3 - Make API Gateway optional #291

huntharo opened this issue Jan 8, 2023 · 0 comments · Fixed by #292
Milestone

Comments

@huntharo
Copy link
Collaborator

huntharo commented Jan 8, 2023

Motivations

  • CDK support for HTTP API Gateways is currently alpha
  • The new Lambda Function URL support is currently all that is used
  • Removing deploy of API Gateway now would speed up deploys

To-Do

  • Make API Gateway optional in all CDK constructs
  • Allow the API Gateway Origin to be missing on the CloudFront distribution
  • Use S3 as the default Origin on CloudFront
  • Add support to change the S3 Origin to a Custom Origin (Lambda etc)
    - [ ] Move MicroAppsAPIGwy into it's own CDK Construct
    - [ ] Remove API Gateway as an option from the MicroApps CDK Construct
    - [ ] Remove the API Gateway npm modules for CDK from the microapps-cdk package
    - [ ] Do not publish the API Gateway CDK Construct for now
    - [ ] Publish the updated MicroApps construct

Items moved to #293 for moving the support into a new module in next minor version.

@huntharo huntharo converted this from a draft issue Jan 8, 2023
huntharo added a commit that referenced this issue Jan 8, 2023
huntharo added a commit that referenced this issue Jan 8, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Make API Gateway optional - default skip

Fixes #291

* Point to S3 origin when no APIgwy origin

* Only add execute-api permission when needed

* Override the S3 origin

* Only upload CDK synth zip when labeled

Saves about two minutes in deploy job

* Try caching installed node modules

* Make more module installs optional

* Fix CDK construct optional install

* Attempt to fix SigV4 failure

* Add OriginShield

* fix path

* Fix module cache for jsii

* Fix createNextDataPathRoute

* Fix app URLs listed on PR

* Fix link
@github-project-automation github-project-automation bot moved this from In Progress to Done in MicroApps Core Jan 8, 2023
@huntharo huntharo added this to the v0.3 milestone Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant