Removed references to font-awesome #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed all references from "fa" and "fa=*" to "pwm-icon" and "pwm-*".
|
Looks good with one exception... I was able to override an icon in a theme by setting a background-image and clearing the content attribute. However, the icon classes are now difficult to search since the prefix is pwm-* making a global search and replace impossible, unlike how it was with fa-. Can you update to have the icon prefix be pwm-icon- instead of pwm-* ? |
|
Sure, I'll make the changes and update the pull request. |
Changed from "pwm-*" to "pwm-icon-*" to make it easier to search for css classes related to icons.
|
OK, the prefixes have all been changed from "pwm-" to "pwm-icon-". @jrivard Please review and merge |
jrivard
added a commit
that referenced
this pull request
Dec 1, 2015
Removed references to font-awesome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed all css class references from "fa" and "fa=" to "pwm-icon" and "pwm-". This should make the HTML more generic, in case themes want to redefine the icon styles.
@jrivard Please review and merge