Update master from dev #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to capitalize on service worker
1. move into service worker. 2. outputting as text files.
This reverts commit 4abb8f0.
…pushing for Judah
… my syntax is wrong...
…rectly, I think it has to do with the axios response handling it.
* Dev (#727) * chore(): update dev from master (#694) * Dev (#692) * Remove specify related applications to be added to the manifest message (#663) * Formatting related application for better display (#666) * Delay mounting codeViewer for milliseconds to fix concurrency issue (#665) * App's log is being used to load home page but not used as a back button (#664) * fix(): fixes #673 (#679) * Bug fix manifest viewer (#681) * display empty string if manifest property's value is falsely * Update the manifest as a key is up * Adding id to access an editor by getElementById on a page * Adding id to the probs and wrapping Monaco editor with a div * Adding resize event listener when it is mounted and remove when component is destroyed * Refactor code to make it DRY * Applying css rules * watching state change and reloading the editor * Debounce helper function is added and call this function to execute update manifest * Fixed undefined in related apps * Putting back event listners when editor is reloaded * Deeplinking pw aurl (#682) * Checking if a query string is matching with pwa url or not * Check a summited pwa url is already part of query string. if not, added it to the url * check and generate if pwa url is already part of query string * Overview and My Hub link is loading using query sting * Log is used to reset and load default page * Process query string and handling browser events * Fixing test fail related to it should fail a bad URL * chore(): update env to point to dev api (#685) * Service worker page cleanup (#686) * fix(): swap top and bottom code viewers * style(): make the code viewer shorter for reg code * Hide broken images (#687) * filter broken icons from the list * suggesion suggest to you to upload at least one image 512×512 or larger * fix(analytics): new markers for build and features * fix(analytics): mark exactly which worker is chosen * fix(analytics): added marker for downloaded service worker Co-authored-by: TesheG <[email protected]> * chore(): re-flip the codeviewers * style(): shorten codeviewer * chore(): update to use pwa-update component Co-authored-by: TesheG <[email protected]> * Fix fonts (#695) * Dev (#692) * Remove specify related applications to be added to the manifest message (#663) * Formatting related application for better display (#666) * Delay mounting codeViewer for milliseconds to fix concurrency issue (#665) * App's log is being used to load home page but not used as a back button (#664) * fix(): fixes #673 (#679) * Bug fix manifest viewer (#681) * display empty string if manifest property's value is falsely * Update the manifest as a key is up * Adding id to access an editor by getElementById on a page * Adding id to the probs and wrapping Monaco editor with a div * Adding resize event listener when it is mounted and remove when component is destroyed * Refactor code to make it DRY * Applying css rules * watching state change and reloading the editor * Debounce helper function is added and call this function to execute update manifest * Fixed undefined in related apps * Putting back event listners when editor is reloaded * Deeplinking pw aurl (#682) * Checking if a query string is matching with pwa url or not * Check a summited pwa url is already part of query string. if not, added it to the url * check and generate if pwa url is already part of query string * Overview and My Hub link is loading using query sting * Log is used to reset and load default page * Process query string and handling browser events * Fixing test fail related to it should fail a bad URL * chore(): update env to point to dev api (#685) * Service worker page cleanup (#686) * fix(): swap top and bottom code viewers * style(): make the code viewer shorter for reg code * Hide broken images (#687) * filter broken icons from the list * suggesion suggest to you to upload at least one image 512×512 or larger * fix(analytics): new markers for build and features * fix(analytics): mark exactly which worker is chosen * fix(analytics): added marker for downloaded service worker Co-authored-by: TesheG <[email protected]> * chore(): re-flip the codeviewers * style(): shorten codeviewer * chore(): update to use pwa-update component * fix(): move to local fonts + icons Co-authored-by: TesheG <[email protected]> * style(): header should be bold * Added pwa-auth to feature store (#701) * Dev (#692) * Remove specify related applications to be added to the manifest message (#663) * Formatting related application for better display (#666) * Delay mounting codeViewer for milliseconds to fix concurrency issue (#665) * App's log is being used to load home page but not used as a back button (#664) * fix(): fixes #673 (#679) * Bug fix manifest viewer (#681) * display empty string if manifest property's value is falsely * Update the manifest as a key is up * Adding id to access an editor by getElementById on a page * Adding id to the probs and wrapping Monaco editor with a div * Adding resize event listener when it is mounted and remove when component is destroyed * Refactor code to make it DRY * Applying css rules * watching state change and reloading the editor * Debounce helper function is added and call this function to execute update manifest * Fixed undefined in related apps * Putting back event listners when editor is reloaded * Deeplinking pw aurl (#682) * Checking if a query string is matching with pwa url or not * Check a summited pwa url is already part of query string. if not, added it to the url * check and generate if pwa url is already part of query string * Overview and My Hub link is loading using query sting * Log is used to reset and load default page * Process query string and handling browser events * Fixing test fail related to it should fail a bad URL * chore(): update env to point to dev api (#685) * Service worker page cleanup (#686) * fix(): swap top and bottom code viewers * style(): make the code viewer shorter for reg code * Hide broken images (#687) * filter broken icons from the list * suggesion suggest to you to upload at least one image 512×512 or larger * fix(analytics): new markers for build and features * fix(analytics): mark exactly which worker is chosen * fix(analytics): added marker for downloaded service worker Co-authored-by: TesheG <[email protected]> * chore(): re-flip the codeviewers * style(): shorten codeviewer * chore(): update to use pwa-update component * chore(): update pwa-install to latest * fix(download): shortcuts must be a real array (#698) Otherwise, llama-pack/bubblewrap will throw the following error: `twaManifest.shortcuts.map is not a function` * chore(): remove use of google fonts and move icons to be served locally (#700) * chore(): update dev from master (#694) * Dev (#692) * Remove specify related applications to be added to the manifest message (#663) * Formatting related application for better display (#666) * Delay mounting codeViewer for milliseconds to fix concurrency issue (#665) * App's log is being used to load home page but not used as a back button (#664) * fix(): fixes #673 (#679) * Bug fix manifest viewer (#681) * display empty string if manifest property's value is falsely * Update the manifest as a key is up * Adding id to access an editor by getElementById on a page * Adding id to the probs and wrapping Monaco editor with a div * Adding resize event listener when it is mounted and remove when component is destroyed * Refactor code to make it DRY * Applying css rules * watching state change and reloading the editor * Debounce helper function is added and call this function to execute update manifest * Fixed undefined in related apps * Putting back event listners when editor is reloaded * Deeplinking pw aurl (#682) * Checking if a query string is matching with pwa url or not * Check a summited pwa url is already part of query string. if not, added it to the url * check and generate if pwa url is already part of query string * Overview and My Hub link is loading using query sting * Log is used to reset and load default page * Process query string and handling browser events * Fixing test fail related to it should fail a bad URL * chore(): update env to point to dev api (#685) * Service worker page cleanup (#686) * fix(): swap top and bottom code viewers * style(): make the code viewer shorter for reg code * Hide broken images (#687) * filter broken icons from the list * suggesion suggest to you to upload at least one image 512×512 or larger * fix(analytics): new markers for build and features * fix(analytics): mark exactly which worker is chosen * fix(analytics): added marker for downloaded service worker Co-authored-by: TesheG <[email protected]> * chore(): re-flip the codeviewers * style(): shorten codeviewer * chore(): update to use pwa-update component Co-authored-by: TesheG <[email protected]> * Fix fonts (#695) * Dev (#692) * Remove specify related applications to be added to the manifest message (#663) * Formatting related application for better display (#666) * Delay mounting codeViewer for milliseconds to fix concurrency issue (#665) * App's log is being used to load home page but not used as a back button (#664) * fix(): fixes #673 (#679) * Bug fix manifest viewer (#681) * display empty string if manifest property's value is falsely * Update the manifest as a key is up * Adding id to access an editor by getElementById on a page * Adding id to the probs and wrapping Monaco editor with a div * Adding resize event listener when it is mounted and remove when component is destroyed * Refactor code to make it DRY * Applying css rules * watching state change and reloading the editor * Debounce helper function is added and call this function to execute update manifest * Fixed undefined in related apps * Putting back event listners when editor is reloaded * Deeplinking pw aurl (#682) * Checking if a query string is matching with pwa url or not * Check a summited pwa url is already part of query string. if not, added it to the url * check and generate if pwa url is already part of query string * Overview and My Hub link is loading using query sting * Log is used to reset and load default page * Process query string and handling browser events * Fixing test fail related to it should fail a bad URL * chore(): update env to point to dev api (#685) * Service worker page cleanup (#686) * fix(): swap top and bottom code viewers * style(): make the code viewer shorter for reg code * Hide broken images (#687) * filter broken icons from the list * suggesion suggest to you to upload at least one image 512×512 or larger * fix(analytics): new markers for build and features * fix(analytics): mark exactly which worker is chosen * fix(analytics): added marker for downloaded service worker Co-authored-by: TesheG <[email protected]> * chore(): re-flip the codeviewers * style(): shorten codeviewer * chore(): update to use pwa-update component * fix(): move to local fonts + icons Co-authored-by: TesheG <[email protected]> * style(): header should be bold Co-authored-by: TesheG <[email protected]> * Added pwa-auth to feature store Co-authored-by: Justin Willis <[email protected]> Co-authored-by: TesheG <[email protected]> Co-authored-by: Christian Liebel <[email protected]> * remove a specific character like period if it is at the end of the string (#703) * Better layout for Feature Store documentation + removing older unused components (Geoloc, Adaptive Card and Copy clipboard). * using generatedUrl than manifest.start_url when icons URL is prepared if it is avaliable (#717) * Edits in manifest reflect in form (#705) * Changing how the model is bound to make a two-way data binding (form to manifest and manifest to for) * Handling manifest change * Manifest is validated if it is a valid JSON format * Debounce manifest’s API call when manifest is changed * Fixed error generating signed APK (#691) * Checking if the src is a valid url and get response back with the help of NodeJS proxy * Getting a good icon from manifest. Start with 512 by 512 and if 512 doesn't exist, loop through all icons * Refactored handleTWA function to get good icon before calling generateSignedApkZip api and display error properly * Excluding uploaded icons which has data:image value to src property * Detecting when an image fails to load * Ensuring promise is resolves * Updated pwa-auth component with apple info (#725) Co-authored-by: TesheG <[email protected]> Co-authored-by: Judah Gabriel Himango <[email protected]> Co-authored-by: Christian Liebel <[email protected]> Co-authored-by: David Rousset <[email protected]> * merge * chore(): update starter to latest (#743) * Starter drop down (#745) * feat(): dropdown for starter flow * feat(): updated design Co-authored-by: TesheG <[email protected]> Co-authored-by: Judah Gabriel Himango <[email protected]> Co-authored-by: Christian Liebel <[email protected]> Co-authored-by: David Rousset <[email protected]>
Co-authored-by: Killian McCoy <[email protected]>
Download generated images
* Fix duplication of path on icons * Improve code comment * Try to fix tests * fix indention problems * Use URL solution instead * Better handling of HTTP sites (#762) * Better UI for score cards on HTTP sites * Fixed #761,download PWA zip for HTTP sites * Removed console.log * [ImgBot] Optimize images (#688) *Total -- 17,288.25kb -> 10,842.25kb (37.29%) /static/Images/assets/icons/apple-icon-192x192-frt5be1ded11c7ec66b00dd234677a5d.png -- 22.59kb -> 8.46kb (62.55%) /static/Images/assets/screenShots/s1.png -- 586.91kb -> 281.68kb (52.01%) /assets/images/pwabuilder-screen.png -- 1,110.49kb -> 550.11kb (50.46%) /static/Images/pwabuilder-screen.png -- 1,110.49kb -> 550.11kb (50.46%) /static/Images/assets/screenShots/s2.png -- 488.40kb -> 242.74kb (50.3%) /assets/images/placeHolder.png -- 8.62kb -> 4.51kb (47.69%) /static/Images/assets/screenShots/s3.png -- 365.47kb -> 197.71kb (45.9%) /assets/images/teams-screen.png -- 1,350.62kb -> 756.01kb (44.03%) /static/Images/teams-screen.png -- 1,350.62kb -> 756.01kb (44.03%) /assets/images/score-icon.png -- 3.15kb -> 1.79kb (43%) /static/Images/assets/icons/apple-icon-512x512-frt5be1ded11c593udsdsdd29fur6732.png -- 81.47kb -> 47.24kb (42.02%) /assets/images/Mask.png -- 2,146.18kb -> 1,265.59kb (41.03%) /assets/images/teams-icon.png -- 2.71kb -> 1.68kb (37.9%) /static/Images/teams-icon.png -- 2.71kb -> 1.68kb (37.9%) /assets/images/android-screen.png -- 847.08kb -> 539.20kb (36.35%) /static/Images/android-screen.png -- 847.08kb -> 539.20kb (36.35%) /assets/images/logo_npm.svg -- 0.72kb -> 0.46kb (35.77%) /static/Images/assets/screenShots/s5.png -- 148.31kb -> 97.47kb (34.28%) /static/Images/assets/screenShots/s4.png -- 134.96kb -> 89.18kb (33.92%) /static/Images/pwa-screen.png -- 1,997.90kb -> 1,330.58kb (33.4%) /assets/images/pwa-screen.png -- 1,997.90kb -> 1,330.58kb (33.4%) /assets/images/logo_stackoverflow.svg -- 1.05kb -> 0.75kb (28.43%) /assets/images/logo_twitter.svg -- 0.96kb -> 0.71kb (26.45%) /assets/images/logo_github.svg -- 1.08kb -> 0.82kb (23.69%) /assets/images/platformScreens/ios.png -- 242.96kb -> 186.04kb (23.43%) /assets/images/goButton.svg -- 0.25kb -> 0.20kb (22.01%) /static/Images/assets/screenShots/s6.png -- 436.60kb -> 341.46kb (21.79%) /assets/images/platformScreens/mac.png -- 203.07kb -> 159.29kb (21.56%) /assets/images/Diagram.png -- 29.76kb -> 23.75kb (20.2%) /assets/images/[email protected] -- 53.67kb -> 42.99kb (19.9%) /assets/images/iphoneDevice.png -- 219.44kb -> 176.14kb (19.73%) /assets/images/gbbChecked.svg -- 0.65kb -> 0.53kb (17.77%) /assets/images/lightBlueO.svg -- 0.83kb -> 0.69kb (17.66%) /assets/images/good.svg -- 1.50kb -> 1.24kb (17.47%) /assets/images/whiteO.svg -- 0.85kb -> 0.71kb (17.28%) /assets/images/lightBlue.svg -- 0.33kb -> 0.27kb (17.01%) /assets/images/gbbNotChecked.svg -- 0.47kb -> 0.39kb (16.95%) /assets/images/androidDevice.png -- 364.02kb -> 302.56kb (16.88%) /assets/images/better_disabled.svg -- 2.77kb -> 2.30kb (16.84%) /assets/images/white.svg -- 0.34kb -> 0.28kb (16.57%) /assets/images/blueO.svg -- 1.12kb -> 0.94kb (16.01%) /assets/images/best_disabled.svg -- 3.96kb -> 3.36kb (15.37%) /assets/images/platformScreens/samsung.png -- 181.11kb -> 153.53kb (15.23%) /assets/images/better.svg -- 2.71kb -> 2.30kb (14.98%) /assets/images/slectedBox.svg -- 1.20kb -> 1.02kb (14.44%) /assets/images/best.svg -- 3.90kb -> 3.35kb (14.06%) /assets/images/platformScreens/teams.png -- 327.41kb -> 282.12kb (13.83%) /assets/images/StackedCube.svg -- 1.44kb -> 1.24kb (13.77%) /assets/images/blue.svg -- 0.63kb -> 0.55kb (13.73%) /assets/images/report_card.svg -- 23.23kb -> 20.18kb (13.15%) /assets/images/platformScreens/pc.png -- 223.54kb -> 194.90kb (12.81%) /assets/images/PWABuilderLogoO.svg -- 2.70kb -> 2.36kb (12.35%) /assets/images/Diagram.svg -- 9.04kb -> 7.95kb (12.03%) /assets/images/bg_publish.svg -- 11.57kb -> 10.28kb (11.21%) /assets/images/PWABuilderLogo.svg -- 1.71kb -> 1.54kb (10.1%) /assets/images/pwaLogo.svg -- 1.60kb -> 1.44kb (9.98%) /static/fonts/icomoon.svg -- 2.84kb -> 2.62kb (8%) /assets/images/publishBackground.svg -- 1.33kb -> 1.30kb (2.2%) /assets/images/publish-bg.svg -- 1.36kb -> 1.33kb (2.09%) /static/fonts/FiraSans-Bold.svg -- 73.33kb -> 72.32kb (1.38%) /static/fonts/FiraSans-Light.svg -- 73.64kb -> 72.63kb (1.37%) /static/fonts/Bitter-Bold.svg -- 86.49kb -> 85.50kb (1.16%) /static/fonts/Bitter-Regular.svg -- 86.97kb -> 85.97kb (1.15%) /assets/images/downloadicon.png -- 0.42kb -> 0.42kb (0.69%) Signed-off-by: ImgBotApp <[email protected]> Co-authored-by: ImgBotApp <[email protected]> Co-authored-by: joel-44 <[email protected]> Co-authored-by: Judah Gabriel Himango <[email protected]> Co-authored-by: Druhin Tarafder <[email protected]> Co-authored-by: ImgBotApp <[email protected]>
Accessibility fixes
Screenshot service
Css for screenshot carousel
Screenshot service
Authored-by: Amrutha Srinivasan <[email protected]>
PWABuilder's Publish page is properly working with navigation
|
Thanks jgw96 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
assigned 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.