Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Notification Message #2

Closed
RElesgoe opened this issue Apr 13, 2014 · 4 comments
Closed

User Notification Message #2

RElesgoe opened this issue Apr 13, 2014 · 4 comments
Labels

Comments

@RElesgoe
Copy link
Member

http://developer.berlios.de/bugs/?func=detailbug&bug_id=15327&group_id=2291
watch.cpp line 184
message_send_text(dest_c, message_type_whisper, NULL, msg); --> message_send_text(dest_c, message_type_whisper, my_c, msg);

@HarpyWar
Copy link
Member

If a user has many friends. and he is talking with someone in whisper at the moment, this will interrupt his dialog when another friend joins the server.

Is /r direction saved for a user without this patch when the server whispers? If not, may be it is better just save it, and not redirect to a friend who joins?

@RElesgoe
Copy link
Member Author

I believe that the client saves the username when while you type /r.
For example:
Friend1: Hello man!
you type: /r Hi
Before you press enter....
Friend2: Want to play a game?
When you press enter, you still send your message to

I still prefer it this way because Battle.net does it and I've rarely had the issue that you've just described.

@HarpyWar HarpyWar added the bug label Apr 15, 2014
@HarpyWar
Copy link
Member

I test it and it looks useful. I also changed the same for /watch.
33dec83

HarpyWar pushed a commit that referenced this issue Feb 12, 2015
@kryshtof
Copy link

It seems both previous and current approach disrupts your conversation (using /r) because when anyone on your friend list joins/leaves game/server your reply either goes to friend who joined/leaved (current) or to server (previous, = error) instead of the person you were whispering to...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants