Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forward-compatibility adaptation for request headers #407

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

efdali
Copy link

@efdali efdali commented Oct 23, 2023

What's this PR do?

    • when we started to use node 18, headers were coming as undefined. we realized that it was caused by these changes on nodejs.

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots (if appropriate)

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e858095) 91.46% compared to head (1796ece) 91.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   91.46%   91.51%   +0.05%     
==========================================
  Files          27       27              
  Lines        1827     1827              
  Branches      398      398              
==========================================
+ Hits         1671     1672       +1     
+ Misses        156      155       -1     
Files Coverage Δ
src/fragment.ts 93.21% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yunusemredilber yunusemredilber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🌸

@mehmetsefabalik mehmetsefabalik merged commit 91bbb58 into puzzle-js:master Oct 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants