Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: runWithId should return the type of the function passed #33

Merged
merged 2 commits into from
Jun 12, 2020
Merged

fix: runWithId should return the type of the function passed #33

merged 2 commits into from
Jun 12, 2020

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Jun 10, 2020

Otherwise doing const thing = rTracer.runWithId(() => '42') would be type any. With this PR the type is string

@SimenB SimenB mentioned this pull request Jun 10, 2020
Merged
puzpuzpuz
puzpuzpuz reviewed Jun 11, 2020
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
puzpuzpuz
puzpuzpuz reviewed Jun 11, 2020
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
@puzpuzpuz puzpuzpuz added the enhancement New feature or request label Jun 11, 2020
@puzpuzpuz puzpuzpuz added this to the 2.2.0 milestone Jun 11, 2020
@puzpuzpuz puzpuzpuz merged commit c60a663 into puzpuzpuz:master Jun 12, 2020
@puzpuzpuz
Copy link
Owner

@SimenB thanks for submitting this fix!

@SimenB SimenB deleted the patch-1 branch June 13, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aigoncharov aigoncharov aigoncharov left review comments

@puzpuzpuz puzpuzpuz puzpuzpuz approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SimenB @puzpuzpuz @aigoncharov