Skip to content

Commit

Permalink
Revert the fix, back to square 1
Browse files Browse the repository at this point in the history
  • Loading branch information
bencroker committed Mar 9, 2024
1 parent cffeae2 commit d641372
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 7 deletions.
4 changes: 0 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@

- Campaign now requires Craft CMS 4.4.0 or later.

### Fixed

- Fixed a bug in which an error could be thrown when very large numbers of contacts were being filtered by segments.

### Deprecated

- Deprecated the `memoryLimit` config setting.
Expand Down
2 changes: 1 addition & 1 deletion src/services/SegmentsService.php
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ private function _getContactElementQuery(array $contactIds = null): ContactEleme
$contactQuery = ContactElement::find();

if ($contactIds !== null) {
$contactQuery->andWhere(['contactId' => $contactIds]);
$contactQuery->id($contactIds);
}

return $contactQuery;
Expand Down
2 changes: 0 additions & 2 deletions src/services/SendoutsService.php
Original file line number Diff line number Diff line change
Expand Up @@ -655,8 +655,6 @@ private function _getPendingRecipientsStandardIds(SendoutElement $sendout): arra
*/
private function _getPendingRecipientsStandard(SendoutElement $sendout): array
{
App::maxPowerCaptain();

$baseCondition = $this->_getPendingRecipientsStandardBaseCondition($sendout);
$contactIds = $this->_getPendingRecipientsStandardIds($sendout);

Expand Down

0 comments on commit d641372

Please sign in to comment.