Fix when buttons appear

putyourlightson · Mar 28, 2024 · b0cf993 · b0cf993
1 parent 7894ba3
commit b0cf993
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Release Notes for Campaign
 
+## 2.13.2 - Unreleased
+
+### Fixed
+
+- Fixed the buttons to create new campaign types and mailing list types appearing when allow admin changes was disabled or the user did not have the necessary permissions.
+
 ## 2.13.1 - 2024-03-26
 
 ### Fixed

diff --git a/composer.json b/composer.json
@@ -1,7 +1,7 @@
 {
   "name": "putyourlightson/craft-campaign",
   "description": "Send and manage email campaigns, contacts and mailing lists.",
-  "version": "2.13.1",
+  "version": "2.13.2",
   "type": "craft-plugin",
   "homepage": "https://putyourlightson.com/plugins/campaign",
   "license": "proprietary",

diff --git a/src/templates/campaigns/index.twig b/src/templates/campaigns/index.twig
@@ -12,14 +12,16 @@
 ]) %}
 
 {% block content %}
-    {% if allCampaignTypes|length == 0 %}
+    {% if allCampaignTypes|length >= 0 %}
         <div class="zilch">
             <p>{{ 'No campaign types exist.'|t('campaign') }}</p>
-            <div style="font-size: initial;">
-                <a href="{{ url('campaign/settings/campaigntypes/new') }}" class="btn submit add icon">
-                    {{ 'New campaign type'|t('campaign') }}
-                </a>
-            </div>
+            {% if craft.app.config.general.allowAdminChanges and currentUser.can('campaign:settings') %}
+                <div style="font-size: initial;">
+                    <a href="{{ url('campaign/settings/campaigntypes/new') }}" class="btn submit add icon">
+                        {{ 'New campaign type'|t('campaign') }}
+                    </a>
+                </div>
+            {% endif %}
         </div>
     {% else %}
         {{ parent() }}

diff --git a/src/templates/mailinglists/index.twig b/src/templates/mailinglists/index.twig
@@ -15,11 +15,13 @@
     {% if allMailingListTypes|length == 0 %}
         <div class="zilch">
             <p>{{ 'No mailing list types exist.'|t('campaign') }}</p>
-            <div style="font-size: initial;">
-                <a href="{{ url('campaign/settings/mailinglisttypes/new') }}" class="btn submit add icon">
-                    {{ 'New mailing list type'|t('campaign') }}
-                </a>
-            </div>
+            {% if craft.app.config.general.allowAdminChanges and currentUser.can('campaign:settings') %}
+                <div style="font-size: initial;">
+                    <a href="{{ url('campaign/settings/mailinglisttypes/new') }}" class="btn submit add icon">
+                        {{ 'New mailing list type'|t('campaign') }}
+                    </a>
+                </div>
+            {% endif %}
         </div>
     {% else %}
         {{ parent() }}