Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ssl with proxy #259

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

stnelso2
Copy link

@stnelso2 stnelso2 commented May 7, 2020

Description of the pull request

... Fix bug #99. This is essentially the same code as PR #176, but it updates the code to work with the version of java_websocket by using WebSocketImpl.DEFAULT_WSS_PORT instead of WebSocket.DEFAULT_WSS_PORT.

Why is the change necessary?

... To fix bug #99


CC @pusher/mobile

@codecov-io
Copy link

Codecov Report

Merging #259 into master will decrease coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #259      +/-   ##
============================================
- Coverage     75.93%   75.77%   -0.16%     
  Complexity      279      279              
============================================
  Files            33       33              
  Lines          2418     2423       +5     
  Branches        112      113       +1     
============================================
  Hits           1836     1836              
- Misses          527      532       +5     
  Partials         55       55              
Impacted Files Coverage Δ Complexity Δ
...t/connection/websocket/WebSocketClientWrapper.java 42.85% <0.00%> (-7.15%) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b47cc4...6301c82. Read the comment docs.

@sonologico
Copy link
Contributor

sonologico commented Oct 21, 2022

Hi. I want to fix the underlying issue (possibly by just merging this), but looking at the current code and the java-websocketclient, I'm not sure this is needed anymore. It seems that setting the proxy and the socketFactory should be enough. Could you confirm that the current code in master is not enough?

EDIT: closed by mistake. Reopened

@sonologico sonologico closed this Oct 21, 2022
@sonologico sonologico reopened this Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants