Require package.json with explicit file extension #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine. I'd like to try and find some time to resolve the issues with node10 and bundle this and the few other open PRs into a new release in the next day or so |
|
This has been fixed in ncc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Zeit Now v2 has a pure request/response model, with no room for long-running connections. Pusher Channels can fill in here. I would guess Node.js is the most popular language on Zeit Now, so pusher-http-node would be our most used library. But pusher-http-node is currently unusable on Zeit Now v2. The underlying bug is on Zeit's end: vercel/ncc#22. But we can fix this sooner ourselves with the change in this PR.