Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially the multi-tab sync system was meant to apply to any new files added to the session. But #58 and #62 showed me that people wanted to share already-open files, which is perfectly reasonable.
Having attempted to make
SharePane
objects of existing active editors, I came across rate-limiting issues. Previously queueing systems applied for things like super-fast typing or large file sharing, but now there is a globalMessageQueue
object. This should ensure that nobody should go out of sync because of rate limiting issues, e.g. when they have lots of large files open and then start a sharing session.In addition to this, customPaste - which threw issues #63 and #48 - has been ditched and its responsibilities assigned to the global queue.
Still a work in progress as I try to flesh out edge cases.