Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Message Queuing System #64

Merged
merged 6 commits into from
Aug 7, 2015
Merged

[WIP] Message Queuing System #64

merged 6 commits into from
Aug 7, 2015

Conversation

jpatel531
Copy link
Contributor

Initially the multi-tab sync system was meant to apply to any new files added to the session. But #58 and #62 showed me that people wanted to share already-open files, which is perfectly reasonable.

Having attempted to make SharePane objects of existing active editors, I came across rate-limiting issues. Previously queueing systems applied for things like super-fast typing or large file sharing, but now there is a global MessageQueue object. This should ensure that nobody should go out of sync because of rate limiting issues, e.g. when they have lots of large files open and then start a sharing session.

In addition to this, customPaste - which threw issues #63 and #48 - has been ditched and its responsibilities assigned to the global queue.

Still a work in progress as I try to flesh out edge cases.

@jpatel531
Copy link
Contributor Author

Still yet to solve the root issue of #58 and #62 - which is why a TextBuffer should be null, whereas the package should ensure a TextEditor for each SharePane. This, however, addresses the circumstance which users said gave rise to those issues.

jpatel531 added a commit that referenced this pull request Aug 7, 2015
[WIP] Message Queuing System
@jpatel531 jpatel531 merged commit 47b69b3 into master Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant