Tests - Caching #67
Open
Tests - Caching #67
+250
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BioPhoton
reviewed
Dec 12, 2024
BioPhoton
requested changes
Dec 19, 2024
projects/nx-verdaccio/src/plugin/utils/caching.utils.unit-test.ts
Outdated
Show resolved
Hide resolved
BioPhoton
reviewed
Dec 20, 2024
BioPhoton
reviewed
Dec 20, 2024
BioPhoton
reviewed
Dec 20, 2024
BioPhoton
reviewed
Dec 20, 2024
BioPhoton
reviewed
Dec 20, 2024
BioPhoton
requested changes
Dec 20, 2024
BioPhoton
reviewed
Jan 5, 2025
BioPhoton
reviewed
Jan 5, 2025
|
I have recheck every comment, and introduced consistency on every layer. |
BioPhoton
requested changes
Jan 5, 2025
There was a problem hiding this comment.
Thanks for checking for duplicate tests and using the right helpers everywhere. The changelog was still formatted. I mentioned that already, linked the old comment and elaborate again why it saves time to do a self review first.
After this small adjustments I think we can get it in! 🥳
| @@ -45,7 +41,7 @@ export function readTargetsCache( | |||
| export function writeTargetsToCache( | |||
| cachePath: string, | |||
| results: Record<string, Partial<ProjectConfiguration>> | |||
| ) { | |||
| ): void { | |||
| process.env.NX_CACHE_PROJECT_GRAPH !== 'false' && | |||
| writeJsonFile(cachePath, results); | |||
There was a problem hiding this comment.
We could use writeJsonFileAsync instead of writeJsonFile to make the code non blocking.
There was a problem hiding this comment.
@BioPhoton What do you think about doing it in seperate pr?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.