Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to not to create mountdr #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kacerr
Copy link

@kacerr kacerr commented Oct 16, 2015

In our case we handle creation of target mount directory somewhere else.
I would like this to be optional. Also i have set default value to true, so if you don't specifically disable mount directory creation it will behave in the same way as before.

@purpleidea
Copy link
Owner

Thanks for the patch. Here's some review:

  • $manage_mount_directory = true # enable/disable creation of directory to mount into

Needs a trailing comma, and a new name. How about we called this option mkdir ?

Secondly, patch is good, but needs to turn off the other two references to ${long_name}. One is a mount require (turn that on or off with a ? operator or reverse the dependency to be a "before" on the file.) and the other spot is the actual mkdir exec which needs to be conditional, right?

Resquash this into a single commit, and test, and I'm happy to merge.

Cheers,
James

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants