Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix laws #32

Merged
merged 5 commits into from
Jul 29, 2017
Merged

Fix laws #32

merged 5 commits into from
Jul 29, 2017

Conversation

hdgarrood
Copy link
Contributor

@hdgarrood hdgarrood commented Jul 29, 2017

This PR includes #23 plus the following changes:

  • uses any and all in the laws, as @paf31 suggested
  • adds a brief explanation of the less intuitive laws

I think this is now good to go, all the discussion points which were raised in #23 have been addressed.

@garyb
Copy link
Member

garyb commented Jul 29, 2017

Looks great to me!

@hdgarrood
Copy link
Contributor Author

Fab. In that case the only outstanding question is whether this counts as a breaking, minor, or patch-level change. I would argue that this should be a patch-level change, as the current set of laws is actually incorrect for pretty much every instance, and I am fairly confident that this new set of laws matches people's assumptions and intuition about how this class should be used, i.e. I expect people will have been using this class as if it had these laws already.

@hdgarrood
Copy link
Contributor Author

🎉

@hdgarrood hdgarrood merged commit d7a0a8b into master Jul 29, 2017
@hdgarrood hdgarrood deleted the fix-laws branch July 29, 2017 17:04
This was referenced Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants