Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upFromIncluding :: ∀ a u. Enum a => Unfoldable u => a -> NonEmpty u a #30

Closed
safareli opened this issue Jun 9, 2017 · 2 comments · Fixed by #31
Closed

upFromIncluding :: ∀ a u. Enum a => Unfoldable u => a -> NonEmpty u a #30

safareli opened this issue Jun 9, 2017 · 2 comments · Fixed by #31

Comments

@safareli
Copy link
Contributor

safareli commented Jun 9, 2017 •
edited
Loading

Thoughts on adding this?

upFromIncluding :: ∀ a u. Enum a => Unfoldable u => a -> NonEmpty u a
upFromIncluding x = NonEmpty x $ upFrom x
@safareli safareli changed the title upFrom' :: forall a u. Enum a => Unfoldable u => a -> NonEmpty u a upFrom' :: ∀ a u. Enum a => Monoid (u a) => Unfoldable u => a -> NonEmpty u a Jun 9, 2017
@safareli safareli changed the title upFrom' :: ∀ a u. Enum a => Monoid (u a) => Unfoldable u => a -> NonEmpty u a upFromIncluding :: ∀ a u. Enum a => Unfoldable u => a -> NonEmpty u a Jun 9, 2017
@paf31
Copy link
Contributor

paf31 commented Jun 9, 2017

👍 I'm surprised upFrom x doesn't start at x actually.

safareli added a commit to safareli/purescript-enums that referenced this issue Jun 10, 2017
@safareli
define upFromIncluding
e5e2fcf 
fix purescript#30
@safareli safareli mentioned this issue Jun 10, 2017
Merged
@safareli
Copy link
Contributor Author

I'm surprised upFrom x doesn't start at x actually.

Yes that was not expecting for me too. but this way upFromIncluding has much correct type :d

@paf31 paf31 closed this as completed in #31 Jun 11, 2017
hdgarrood pushed a commit that referenced this issue Jul 29, 2017
@safareli @hdgarrood
define upFromIncluding
e3844b7 
fix #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

define upFromIncluding safareli/purescript-enums
2 participants
@paf31 @safareli