fix Date/Instant construction for years 0 <= y < 100 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, thanks! I don't mind the duplicated function in the FFI (I saw the discussion on Slack), I think this is probably the best way to handle it to keep things as simple as possible in terms of FFI modules, etc. |
berdario
added a commit
to berdario/purescript-js-date
that referenced
this pull request
Jun 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46.
Dateconstructors in JS assume years between1900-1999when year argumentyis0 <= y < 100.Unfortunately there's no constructor function to overcome that assumption, the only way is to use
setUTCFullYear.I'm pretty new to PS so criticism is most welcome. 👍