This repository has been archived by the owner on Oct 4, 2020. It is now read-only.
TouchEvent support #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyb
suggested changes
Jun 1, 2017
| item i = toMaybe <<< _item i | ||
|
|
||
| eventToTouchEvent :: Event -> F TouchEvent | ||
| eventToTouchEvent = readTouchEvent <<< toForeign |
There was a problem hiding this comment.
We don't provide these upcasts for any of the other event types as part of this library, so don't really need this one either. purescript-dom-classy covers this sort of thing instead. :)
There was a problem hiding this comment.
I copied eventToTouchEvent from MouseEvent, also present in ClipboardEvent, CompositionEvent, FocusEvent, KeyboardEvent and WheelEvent. Are those kept for backwards compatibility?
There was a problem hiding this comment.
Uhh ok, I guess I'm wrong! I didn't think we provided those. 😄
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.