This repository has been archived by the owner on Oct 4, 2020. It is now read-only.
Handle cases where DataTransfer has a null +files+ slot #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On firefox, the +files+ property on the DataTransfer object is intentionally left null from dragover and dragenter events. Relevant bug: https://bugzilla.mozilla.org/show_bug.cgi?id=640534 Since this isn't likely to be fixed by mozilla, the files function should account for the possibility of a null.
Fixes broken CI run.
Fixes CI build.
|
Thanks for addressing this. Elsewhere we use |
|
Sure thing. I didn't notice that. |
Replaces the Maybe constructor passing I was using, following the convention already established else where.
|
I think this is ready now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On firefox, the +files+ property on the DataTransfer object is
intentionally left null from dragover and dragenter events.
Relevant bug: https://bugzilla.mozilla.org/show_bug.cgi?id=640534
Since this isn't likely to be fixed by mozilla, the files function should
account for the possibility of a null.