Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spago.dhall to add missing direct dependencies #41

Merged

Conversation

ntwilson
Copy link
Contributor

Description of the change
Adds in missing direct dependencies to spago.dhall to pass the CI checks. (See purescript-contrib/governance#43)


Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@@ -20,10 +20,10 @@
"dependencies": {
"purescript-effect": "^3.0.0",
"purescript-functions": "^5.0.0",
"purescript-maybe": "^5.0.0"
"purescript-maybe": "^5.0.0",
"purescript-prelude": "^5.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't prelude be 5.0.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I did was check the .spago directory contents after doing a spago build:
image

@thomashoneyman thomashoneyman merged commit 7333261 into purescript-contrib:main Jul 28, 2021
@ntwilson ntwilson deleted the fix-ci-dependencies branch July 28, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants