Remove note about specific effect type #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdgarrood
reviewed
Oct 1, 2020
src/Data/JSDate.purs
Outdated
| @@ -153,8 +153,8 @@ foreign import dateMethod :: forall a. Fn2 String JSDate a | |||
| -- | behaviour for a given string. The RFC2822 and ISO8601 date string formats | |||
| -- | should parse consistently. | |||
| -- | | |||
| -- | The `LOCALE` effect is present here as if no time zone is specified in the | |||
| -- | string the current locale's time zone will be used instead. | |||
| -- | This function is effectful in the sense that if no time zone is specified | |||
There was a problem hiding this comment.
I think "in the sense that" can be shortened to "because" here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the reference to the specific
LOCALEeffect in theparsedocs, as this function now returns a genericEffect.