feat(#91): add decoder for NonEmptyString #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
94
to
95
| decodeNonempty :: Json -> Either JsonDecodeError String | ||
| decodeNonempty = map NonEmptyString.toString <<< decodeNonEmptyString |
There was a problem hiding this comment.
I'd rather not include this function; it's pretty easy to do map NonEmptyString.toString in your own code and we don't otherwise provide functions beyond the initial parse in the library.
| pure Nothing | ||
| else |
There was a problem hiding this comment.
Where did all these come from? 😅 Thanks for trimming the whitespace.
|
Done |
|
@srghma I won’t be able to make a new release containing this new function until we make the library releases for 0.14. However it’ll be available at that point! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
feat(#91): add decoder for NonEmptyString
Checklist: