Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #87 #88

Merged
merged 3 commits into from
Aug 30, 2020
Merged

Fix for #87 #88

merged 3 commits into from
Aug 30, 2020

Conversation

BrandonHowe
Copy link
Contributor

@BrandonHowe BrandonHowe commented Aug 30, 2020 •
edited
Loading

Description of the change
Fixes a small error with the docs showing String instead of JsonDecodeError

Closes #87

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

thomashoneyman
thomashoneyman approved these changes Aug 30, 2020
View reviewed changes
Copy link
Contributor

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thomashoneyman thomashoneyman merged commit 3aaf147 into purescript-contrib:main Aug 30, 2020
@BrandonHowe BrandonHowe deleted the patch-1 branch September 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong type shown in docs
2 participants
@BrandonHowe @thomashoneyman