-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New tutorial for argonaut-codecs #62
Conversation
As someone who's been confused about Argonaut and about how I was supposed to do things, this tutorial is awesome! It answers pretty much all my questions and after reading I feel like I have a good grasp on things. Here's some minor ideas on how to make things even better:
Anyway, this tutorial is great. Thanks a lot for writing it. |
Thanks for the feedback!
Good points! It's a bit confusing having three separate libraries which can be used separately but which are designed to be used together. In each case a possible newcomer ought to get a feel for what Argonaut is about, even if they aren't looking at the With regards to being a general introduction to Argonaut: that's true. The I don't feel like the topics talked about here (encoding and decoding
This is a good point. I'll add those links.
Yes, there are some redundancies there. I think the tutorial would be better with those removed as well. Thanks! |
address feedback from @paldepind and improve relevant sections of the tutorial
That sounds like a great idea. And each of these could have a "beginners see this tutorial" link. The changes looks great 👍 |
Excellent! I'll let this sit for another day or two, but if there are no further comments then I will merge this in. Further updates can always be made. |
What does this pull request do?
Closes #48 and adds an in-depth tutorial to introduce new users to the library, provide them with the tools they need to perform common tasks, and includes a few problem situations along with their solutions at the end. I think it's critical that a new Argonaut user feels comfortable creating encoders and decoders for simple data types without having to look at tests, search for random examples across the web, or rely on Haskell or Scala documentation instead.
Where should the reviewer start?
All changes are to the README.
How should this be manually tested?
There is no new code to test, but if you'd like to try things out in the REPL and make sure there aren't errors, that would help; this also deserves an error-checking proofread.
To read the pretty, non-diff version of the file, use this link:
https://github.com/purescript-contrib/purescript-argonaut-codecs/blob/05d25c2ec89380dc7c6e8fdbc755150983bc0115/README.md
Other Notes:
If I am missing any common scenarios that really ought to be covered by a tutorial, I am happy to add them in as well and am open to suggestions to improve this! They can also be subsequent pull requests.