Generic deriving #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,6 +44,44 @@ import qualified Data.Map as Map | |||
| class DecodeJson a where | |||
| decodeJson :: Json -> Either String a | |||
|
|
|||
| -- | Decode `Json` representation of a value which has a `Generic` type. | |||
| gDecodeJson :: forall a. (Generic a) => Json -> Either String a | |||
| gDecodeJson = map (fromJust <<< fromSpine) | |||
There was a problem hiding this comment.
We should eliminate this fromJust and instead return a Left with some appropriate error message.
There was a problem hiding this comment.
@jdegoes That's right. Fixed.
|
Looks great! Three minor nitpicks:
👍 Thanks for your work on this! |
|
@jdegoes Nitpicks are welcome.
|
|
(1) and (2) look fine. For (3), I meant, create a more complex data structure to exercise all the types exposed in Generic. |
|
@jdegoes Makes sense. Fixed. |
|
👍 Awesome work! Can you squash commits one more time and I'll merge in? |
|
Upps. Broke it while rebasing, fixing now. |
|
Ready to be merged now |
|
👍 Thanks again! |
|
@jdegoes Thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be quite ready now.