Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings and missing direct dependencies causing CI failures #103

Merged
merged 1 commit into from
Jul 28, 2021
Merged

fix warnings and missing direct dependencies causing CI failures #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions bower.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,28 @@
"dependencies": {
"purescript-argonaut-core": "^6.0.0",
"purescript-arrays": "^6.0.0",
"purescript-bifunctors": "^5.0.0",
"purescript-effect": "^3.0.0",
"purescript-either": "^5.0.0",
"purescript-foldable-traversable": "^5.0.0",
"purescript-foreign-object": "^3.0.0",
"purescript-identity": "^5.0.0",
"purescript-integers": "^5.0.0",
"purescript-lists": "^6.0.0",
"purescript-maybe": "^5.0.0",
"purescript-nonempty": "^6.0.0",
"purescript-ordered-collections": "^2.0.0",
"purescript-prelude": "^5.0.0",
"purescript-record": "^3.0.0"
"purescript-record": "^3.0.0",
"purescript-strings": "^5.0.0",
"purescript-tuples": "^6.0.0"
},
"devDependencies": {
"purescript-assert": "^5.0.0",
"purescript-console": "^5.0.0",
"purescript-quickcheck": "^7.0.0"
"purescript-exceptions": "^5.0.0",
"purescript-gen": "^3.0.0",
"purescript-quickcheck": "^7.0.0",
"purescript-transformers": "^5.0.0"
}
}
9 changes: 9 additions & 0 deletions spago.dhall
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,27 @@
[ "argonaut-core"
, "arrays"
, "assert"
, "bifunctors"
, "console"
, "effect"
, "either"
, "exceptions"
, "foldable-traversable"
, "foreign-object"
, "gen"
, "identity"
, "integers"
, "lists"
, "maybe"
, "nonempty"
, "ordered-collections"
, "prelude"
, "psci-support"
, "quickcheck"
, "record"
, "strings"
, "transformers"
, "tuples"
]
, packages = ./packages.dhall
, sources = [ "src/**/*.purs", "test/**/*.purs" ]
Expand Down
4 changes: 2 additions & 2 deletions test/Test/Main.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ combinatorsCheck = do
obj <- genObj
let appended = (key := val) ~> obj
case toObject appended >>= FO.lookup key of
Just value -> pure Success
Just _ -> pure Success
_ -> pure (Failed "failed to lookup key")

propAssocAppendOptional :: Gen Result
Expand All @@ -195,7 +195,7 @@ combinatorsCheck = do
obj <- genObj
let appended = (key :=? maybeVal) ~>? obj
pure case toObject appended >>= FO.lookup key of
Just value -> isJust maybeVal === true
Just _ -> isJust maybeVal === true
_ -> isNothing maybeVal === true

propGetJObjectField :: Gen Result
Expand Down