Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing deps #205

Merged

Conversation

pete-murphy
Copy link
Contributor

@pete-murphy pete-murphy commented Jul 27, 2021

Description of the change

This adds missing dependencies listed when running spago build (see: purescript-contrib/governance#43)

Output from running spago build before these changes
[info] Build succeeded.
[warn] None of your project files import modules from some projects that are in the direct dependencies of your project.
These dependencies are unused. To fix this warning, remove the following packages from the list of dependencies in your config:
- free
[error] Some of your project files import modules from packages that are not in the direct dependencies of your project.
To fix this error add the following packages to the list of dependencies in your config:
- arrays
- bifunctors
- control
- either
- foldable-traversable
- maybe
- newtype
- prelude
- refs
- tailrec
You may add these dependencies by running the following command:
spago install arrays bifunctors control either foldable-traversable maybe newtype prelude refs tailrec


Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

CHANGELOG.md Outdated Show resolved Hide resolved
@thomashoneyman
Copy link
Contributor

This looks good, though it's now revealing some unused name errors -- would you mind taking a look at those? Thank you!

@pete-murphy pete-murphy force-pushed the pm/fix-ci-spago-deps branch from d65083f to baaabae Compare July 28, 2021 01:44
@pete-murphy pete-murphy force-pushed the pm/fix-ci-spago-deps branch from baaabae to 3e77de4 Compare July 28, 2021 01:45
@pete-murphy
Copy link
Contributor Author

Sorry for the force push, got confused which repo I was in 😅

@thomashoneyman
Copy link
Contributor

No worries 😆 Also, I don't know if you saw it yet, but I updated the original issue to recommend not worrying about the bower.json files. They're a bit of a mess and you can just leave them as-is. I can tweak them as needed before publishing the library; they aren't used in local development anymore.

@thomashoneyman thomashoneyman merged commit 888d938 into purescript-contrib:main Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants