fix(rollup): fixed error from migration from webpack to rollup

fixed error from migration from webpack to rollup that left decoders as an external dependency
purecloudlabs · Jan 18, 2024 · a243dcd · a243dcd
1 parent 9ccdab2
commit a243dcd
Show file tree

Hide file tree

Showing 6 changed files with 172 additions and 8 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -31,7 +31,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: "16"
+          node-version: "18.14.2"
 
       # Install dependencies
       - run: npm ci

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/iframe-coordinator-cli/package.json b/packages/iframe-coordinator-cli/package.json
@@ -20,8 +20,6 @@
   },
   "devDependencies": {
     "@vitejs/plugin-vue2": "^2.3.1",
-    "jsdom": "^23.2.0",
-    "karma-jsdom-launcher": "^16.0.0",
     "typescript": "^4.9.5",
     "vite": "^5.0.11"
   },

diff --git a/packages/iframe-coordinator/karma.conf.ts b/packages/iframe-coordinator/karma.conf.ts
@@ -21,5 +21,6 @@ module.exports = (config) => {
     browsers: ["jsdom"],
     singleRun: false,
     concurrency: Infinity,
+    hostname: "127.0.0.1",
   });
 };
diff --git a/packages/iframe-coordinator/package.json b/packages/iframe-coordinator/package.json
@@ -16,12 +16,16 @@
   "module": "dist/index.js",
   "types": "dist/index.d.ts",
   "devDependencies": {
+    "@rollup/plugin-commonjs": "^25.0.7",
+    "@rollup/plugin-node-resolve": "^15.2.3",
     "@rollup/plugin-replace": "^5.0.5",
     "@rollup/plugin-typescript": "^11.1.5",
     "@types/jasmine": "^5.1.4",
     "jasmine-core": "^5.1.1",
+    "jsdom": "^23.2.0",
     "karma": "^6.4.2",
     "karma-jasmine": "^5.1.0",
+    "karma-jsdom-launcher": "^16.0.0",
     "karma-typescript": "^5.5.4",
     "puppeteer": "^21.7.0",
     "rollup": "^4.9.4",

diff --git a/packages/iframe-coordinator/rollup.config.js b/packages/iframe-coordinator/rollup.config.js
@@ -1,5 +1,8 @@
 import typescript from "@rollup/plugin-typescript";
 import replace from "@rollup/plugin-replace";
+import { nodeResolve } from "@rollup/plugin-node-resolve";
+import commonjs from "@rollup/plugin-commonjs";
+
 import fs from "fs";
 
 const packageVersion = JSON.parse(
@@ -13,7 +16,6 @@ export default [
       file: "dist/index.js",
       format: "es",
     },
-    external: ["decoders"],
     plugins: [
       typescript(),
       replace({
@@ -22,6 +24,8 @@ export default [
           __PACKAGE_VERSION__: packageVersion,
         },
       }),
+      commonjs(),
+      nodeResolve(),
     ],
   },
   {
@@ -30,7 +34,6 @@ export default [
       file: "dist/client.js",
       format: "es",
     },
-    external: ["decoders"],
     plugins: [
       typescript(),
       replace({
@@ -39,6 +42,8 @@ export default [
           __PACKAGE_VERSION__: packageVersion,
         },
       }),
+      commonjs(),
+      nodeResolve(),
     ],
   },
   {
@@ -47,7 +52,6 @@ export default [
       file: "dist/host.js",
       format: "es",
     },
-    external: ["decoders"],
     plugins: [
       typescript(),
       replace({
@@ -56,6 +60,8 @@ export default [
           __PACKAGE_VERSION__: packageVersion,
         },
       }),
+      commonjs(),
+      nodeResolve(),
     ],
   },
 ];