-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡ Reduce code binary size #708
base: develop-pros-4
Are you sure you want to change the base?
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Explanation for these changes please? I'm unclear on why you're making like, any of them. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Pull request contains merge conflicts. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
tested, works |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
this works, tests successful |
Here is the size difference of the cold package when using with They are exactly the same size. This indicates that
There are 2 points in the text that support this:
PROS uses an AAPCS configuration
The Cortex A9 in the brain uses the "arm-v7" architecture, which is not a "pre-v5" architecture, implying that this option is not needed. Since it has been shown PROS works without issue without the |
Remove uneeded sections, and sort sections by alignment to reduce padding
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@ion098 is this ready to be merged? |
@SizzinSeal Yes, this is ready to be merged now. |
@Rocky14683 the download link is invalid |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@Rocky14683 would you be able to rerun the pipeline? The pipeline seemed to not download the toolchain properly for some reason. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This PR saves reduces the size of the cold package by 34,240 bytes when compared to what is currently on the develop-pros-4 branch. In terms of upload time, this saves about 2-3 seconds when uploading the cold package wirelessly. |
Summary:
This PR reduces the memory footprint of PROS projects; it does this by reducing code size through the usage of Thumb mode, as well as removing unneeded linker sections.
Motivation:
Reducing memory footprint means smaller upload times.
Test Plan: