Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Increase max text length for controller text setting #683

Open
wants to merge 2 commits into
base: develop-pros-4
Choose a base branch
from

Conversation

ion098
Copy link
Contributor

@ion098 ion098 commented Jun 28, 2024

Summary:

Changes max length of controller text to 31 characters.

Motivation:

VEXCode allows users to set controller text with a maximum length of 31 characters, but PROS caps controller text at 15 characters.

References (optional):

Close #679

Test Plan:

  • Check it compiles
  • Check that controller text setting works with strings up to 31 characters long
  • Check that this doesn't break controller text clearing

@noam987
Copy link
Contributor

noam987 commented Jun 28, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BennyBot
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

AndrewLuGit
AndrewLuGit previously approved these changes Oct 24, 2024
Copy link
Contributor

@AndrewLuGit AndrewLuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liucougar
Copy link

this would be nice to have

Copy link
Member

@WillXuCodes WillXuCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight change requested

src/devices/controller.c Outdated Show resolved Hide resolved
@@ -18,7 +18,8 @@
#include "v5_api.h"
#include "vdml/vdml.h"

#define CONTROLLER_MAX_COLS 15
#define CONTROLLER_MAX_COLS ( 20U )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed from 15 to 20?

Copy link
Contributor Author

@ion098 ion098 Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because VEXCode supports 20 columns:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛[BUG] - Controller text cuts off too early
6 participants