Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix motor groups not properly setting motor gearing/encoder units #610

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/devices/vdml_motorgroup.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,16 @@ MotorGroup::MotorGroup(const std::initializer_list<std::int8_t> ports,
const pros::v5::MotorGears gearset,
const pros::v5::MotorUnits encoder_units)
: _ports(ports) {
set_gearing(gearset);
set_encoder_units(encoder_units);
set_gearing_all(gearset);
set_encoder_units_all(encoder_units);
}

MotorGroup::MotorGroup(const std::vector<std::int8_t>& ports,
const pros::v5::MotorGears gearset,
const pros::v5::MotorUnits encoder_units)
: _ports(ports) {
set_gearing(gearset);
set_encoder_units(encoder_units);
set_gearing_all(gearset);
set_encoder_units_all(encoder_units);
}

std::int32_t MotorGroup::operator=(std::int32_t voltage) const {
Expand Down