✨Add ADI Addressable LED Support #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the C++ api, couldn't we have the led object automatically manage the buffer? When the ADILED object is created, the class can automatically generate an RGB buffer from the number of LEDS the strip has, then the we can have an overload that lets the user access individual elements of the led strip: pros::ADILed ledStrip(port, num_leds); // Create the led strip object
ledStrip[0] = 0xFF00FF; // Set the first pixel to purple
ledStrip.update(); // Send the rgb values to the stripThis would be safer for the end user (which is more C++ like), and easier. Would could probably also provide functions for setting a range of pixels to the same value. |
sy1vi3
reviewed
Oct 10, 2022
There was a problem hiding this comment.
ext_adi_led_init() appears to work perfectly fine, but ext_adi_led_set() and ext_adi_led_set_pixel() do not.
I'm getting weird issues with program hanging, it's not making sense.
I can get lights to turn on by calling ext_adi_led_init() with 1-indexed port numbers, then using the SDK functions directly to set the lights to on.
subtracted 1 from smart_port because it needs to be zero-indexed 🙃
fix ext_adi_led_set and ext_adi_led_set_pixel
Fixed port decrement/increment issue in the c api's init and set functions, as well as the c++ api's addrled ctor fixed issue with ext_adi_led_set always returning PROS_ERR because (... || buffer_length) is always true tested changes on actual hardware to make sure they work
forgot the newline at the end
Co-authored-by: Will Xu <[email protected]>
Co-authored-by: Will Xu <[email protected]>
Co-authored-by: Will Xu <[email protected]>
Fixed C and C++ addrled APIs so that they actually work now
WillXuCodes
approved these changes
Oct 12, 2022
|
AWESOME |
WillXuCodes
added a commit
that referenced
this pull request
Oct 18, 2022
* Implement C functions to set buffer, clear buffer * C layer * Implement C++ layer * Typo fix bool * Add test code, add get_state and set_state * Test code typooo * Update vdml_adi.c * Smart port offset for inherited funcs (digital write and read)) * Fix return type of get_state * Fix inheritance to ADIPort instead of DigitalOut * Add newlines * Change set_state to turn * Check buffer_length, buffer_length as member * Add buffer as class member * Fix typo * Types and operator[] declaration * Typo * Fix some stuff * Change _buffer from pointer to vector * Use .data() * Add cast * Fix docs, code, and refine API. * Fix return types * Revert main * Add debug txt * Add more debug text * Fix value issue with smart port * Fix debug prints * Enhance debug statements * fix ext_adi_led_set and ext_adi_led_set_pixel subtracted 1 from smart_port because it needs to be zero-indexed 🙃 * Clean code up * fix port claiming on set * Fix accidental decrement * Fixed C and C++ addrled APIs so that they actually work now Fixed port decrement/increment issue in the c api's init and set functions, as well as the c++ api's addrled ctor fixed issue with ext_adi_led_set always returning PROS_ERR because (... || buffer_length) is always true tested changes on actual hardware to make sure they work * put gitignore back like it was oops * fix gitignore again forgot the newline at the end * Update src/devices/vdml_ext_adi.c Co-authored-by: Will Xu <[email protected]> * Update version Co-authored-by: Will Xu <[email protected]> * Update include/api.h Co-authored-by: Will Xu <[email protected]> * remove string include * fixed indent * fix spacing in for loop Co-authored-by: Will Xu <[email protected]> Co-authored-by: Sylvie <[email protected]> Co-authored-by: Will Xu <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds support for the VEX ADI LED
Motivation:
Self-explanatory
References (optional):
Closes #424
Test Plan:
Test code is in main.cpp. Plug in LEDs to port and run.