Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Refactor linker scripts #213

Merged
merged 2 commits into from
Mar 16, 2020
Merged

Conversation

edjubuh
Copy link
Member

@edjubuh edjubuh commented Feb 29, 2020

Summary:

Refactor linker scripts such that memory regions are defined in first linker script processed and standard section placement is performed last. v5-common.ld and v5.ld "swapped" and v5-common.ld is now explicitly mentioned in LNK_FLAGS (last)

Motivation:

Better support custom linker scripts from user templates (e.g. libconsole).
In order to support custom linker scripts from user templates (e.g. libconsole),

References (optional):

Test Plan:

  • Still can compile/run monolith
  • Still can compile/run hot/cold

In order to support custom linker scripts from user templates (e.g.
libconsole), refactor linker scripts such that memory regions are
defined in first linker script processed and standard section placement
is performed last.
@edjubuh edjubuh added the enhancement This builds on top of an existing feature label Feb 29, 2020
@edjubuh edjubuh self-assigned this Feb 29, 2020
Forgot to move, hot/cold now works.
edjubuh added a commit to edjubuh/libconsole that referenced this pull request Mar 1, 2020
@edjubuh edjubuh removed their assignment Mar 6, 2020
@HotelCalifornia HotelCalifornia merged commit 065b9d4 into develop Mar 16, 2020
@HotelCalifornia HotelCalifornia deleted the feature/refactor-linker-scripts branch September 13, 2020 07:39
@kunwarsahni01 kunwarsahni01 mentioned this pull request Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This builds on top of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants