Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Fix header tracking of duplicate basename files #191

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

nathan-moore
Copy link
Member

@nathan-moore nathan-moore commented Jan 1, 2020

Summary:

While working on another pr, I noticed we weren't generating header change tracking files for files with the same name, but different extensions. This reworks generating those based on the full un-compiled names, similar to what we do with object files.

Some people in discord were also getting confused when a file failed to compile, a could not move error from mv was showing. This also silences that.

Misc makefile cleanup from my changes.

Motivation:

Files only sometimes recompiling isn't fun, though the kernel is likely the only people to hit this.

References (optional):

None

Test Plan:

  • Compile the kernel and check that the appropriate tracking files are generated.
  • When a file can't be compiled, there isn't a move error.

@nathan-moore nathan-moore changed the title Fix header tracking of duplicate basename files 🐛Fix header tracking of duplicate basename files Jan 4, 2020
@HotelCalifornia HotelCalifornia added this to the 3.2.1 milestone Jan 21, 2020
@HotelCalifornia HotelCalifornia added enhancement This builds on top of an existing feature in testing This is currently in testing p: normal Normal priority labels Jan 21, 2020
Copy link
Contributor

@HotelCalifornia HotelCalifornia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HotelCalifornia HotelCalifornia merged commit a124885 into develop Jan 21, 2020
@nathan-moore nathan-moore deleted the bugfix/FixCompilationForSameFileNames branch January 23, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This builds on top of an existing feature in testing This is currently in testing p: normal Normal priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants